[evolution-patches] 67170, nntp subscribe broken
- From: Not Zed <notzed ximian com>
- To: asdf <evolution-patches lists ximian com>
- Subject: [evolution-patches] 67170, nntp subscribe broken
- Date: Fri, 08 Oct 2004 16:17:04 +0800
for some reason some of the code incorrectly did case insensitive compares, causing problems when there were overlaps since the rest of the code uses case sensitive compares.
Index: camel/ChangeLog
===================================================================
RCS file: /cvs/gnome/evolution/camel/ChangeLog,v
retrieving revision 1.2251.2.13
diff -u -3 -r1.2251.2.13 ChangeLog
--- camel/ChangeLog 6 Oct 2004 11:39:44 -0000 1.2251.2.13
+++ camel/ChangeLog 8 Oct 2004 08:20:16 -0000
@@ -1,3 +1,11 @@
+2004-10-08 Not Zed <NotZed Ximian com>
+
+ ** See bug #67170.
+
+ * providers/nntp/camel-nntp-store.c
+ (nntp_store_get_cached_folder_info): compare newsgroup names case
+ sensitively.
+
2004-10-05 Not Zed <NotZed Ximian com>
** See bug #67527.
Index: camel/providers/nntp/camel-nntp-store.c
===================================================================
RCS file: /cvs/gnome/evolution/camel/providers/nntp/camel-nntp-store.c,v
retrieving revision 1.65.14.6
diff -u -3 -r1.65.14.6 camel-nntp-store.c
--- camel/providers/nntp/camel-nntp-store.c 29 Sep 2004 01:57:11 -0000 1.65.14.6
+++ camel/providers/nntp/camel-nntp-store.c 8 Oct 2004 08:20:16 -0000
@@ -650,8 +650,8 @@
int toplen = strlen(top);
for (i = 0; (si = camel_store_summary_index ((CamelStoreSummary *) store->summary, i)); i++) {
- if ((subscribed_or_flag || (si->flags & CAMEL_STORE_INFO_FOLDER_SUBSCRIBED)) &&
- (root_or_flag || g_ascii_strncasecmp (si->path, top, toplen) == 0)) {
+ if ((subscribed_or_flag || (si->flags & CAMEL_STORE_INFO_FOLDER_SUBSCRIBED))
+ && (root_or_flag || strncmp (si->path, top, toplen) == 0)) {
if (recursive_flag || strchr (si->path + toplen, '.') == NULL) {
/* add the item */
fi = nntp_folder_info_from_store_info(store, FALSE, si);
@@ -666,7 +666,7 @@
the item we added last, we need to add a portion of this item to
the list as a placeholder */
if (!last ||
- g_ascii_strncasecmp(si->path, last->full_name, strlen(last->full_name)) != 0 ||
+ strncmp(si->path, last->full_name, strlen(last->full_name)) != 0 ||
si->path[strlen(last->full_name)] != '.') {
tmpname = g_strdup(si->path);
*(strchr(tmpname + toplen, '.')) = '\0';
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]