Re: [evolution-patches] Patch to fix dist in help/C/



2004-10-04, 15:40 -0400, Rodney Dawes: 
> I don't think this patch should go in. It doesn't solve anything. It
> just changes the behaviour of the CLEAN rules on a pedantic level, and
> the problem will appear again later, once the underlying problems are
> actually solved, except it will just be the reverse pedantic problem.

> The current behaviour in CVS is the correct thing to do for the current
> tools and their bugs or misbehaviours.

OK, let me summarize: the generated files are expected to be removed by
clean rule, but the docs makefiles incorrectly distribute the files.
Then it's ok.  Just don't forget to fix the underlying bug.

My patch was to change the make clean behavior to distribute the
generated files correctly.  This is the makefile convention which has
been used and accepted widely, not just a pedantic level change.  

In the case of deb packaging, usual debian packages use "make distclean"
*before* building source packages.  So if distclean removes any
distributed file, diff size will be increased unnessarily or diff fails.

-- 
Changwoo Ryu <cwryu debian org>

Attachment: signature.asc
Description: This is a digitally signed message part



[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]