Re: [evolution-patches] Mailing list actions
- From: Not Zed <notzed ximian com>
- To: Meilof Veeningen <meilof wanadoo nl>
- Cc: Evolution-patches <evolution-patches lists ximian com>
- Subject: Re: [evolution-patches] Mailing list actions
- Date: Wed, 17 Nov 2004 09:16:45 +0800
I thought i had.
I still think I did, unless i only did the previous patch.
On Wed, 2004-11-17 at 00:58 +0100, Meilof Veeningen wrote:
Hello,
So is this going to get committed? I thought it was pretty complete:
http://lists.ximian.com/archives/public/evolution-patches/2004-November/008108.html
Meilof
-- meilof wanadoo nl
|
text/plain attachment (eplug-mailing-list-actions-patch2)
|
? Makefile
? Makefile.in
? eplug-mailing-list-actions-patch1
? eplug-mailing-list-actions-patch2
? mailing-list-actions-hdrs.c
? mailing-list-actions-orig.c
? org-gnome-mailing-list-actions.eplug
Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/evolution/plugins/mailing-list-actions/ChangeLog,v
retrieving revision 1.1
diff -r1.1 ChangeLog
0a1,16
> 2004-11-04 Meilof Veeningen <meilof wanadoo nl>
>
> * org-gnome-mailing-list-actions.eplug.in: Added author tag, fixed
> description, removed "plugin" from name, changed position of item
> in popup menu, using "enable" rather than "visible" for bonobo menus
>
> * org-gnome-mailing-list-actions.xml: Now place menus in
> MailMessageActions placeholder; moved label to <commands> section
>
> * org-gnome-mailing-list-actions-errors.xml: fixed button order:
> "Cancel" now leftmost button; added e-mail address to send confirm
> dialog
>
> * mailing-list-actions.c: account guessing now first based on message;
> added e-mail address to send confirm dialog
>
Index: mailing-list-actions.c
===================================================================
RCS file: /cvs/gnome/evolution/plugins/mailing-list-actions/mailing-list-actions.c,v
retrieving revision 1.1
diff -r1.1 mailing-list-actions.c
95c95
< const char* header = NULL, *headerpos;
---
> const char* header = NULL, *headerpos, *fromurl = NULL;
101c101
< EAccount *account;
---
> EAccount *account = NULL;
140c140
< if (emla_action_headers[t].interactive)
---
> if (emla_action_headers[t].interactive) {
142,143c142,152
< else
< send_message_response = e_error_run (NULL, "org.gnome.mailing-list-actions:ask-send-message", url, NULL);
---
> } else {
> fromurl = camel_mime_message_get_source (msg);
> account = mail_config_get_account_by_source_url (fromurl);
> if (!account) {
> fromurl = action_data->uri;
> account = mail_config_get_account_by_source_url (fromurl);
> }
> send_message_response = e_error_run (NULL, "org.gnome.mailing-list-actions:ask-send-message",
> (account && account->id && account->id->address) ? account->id->address : "(default e-mail)",
> url, NULL);
> }
148c157
< if ((account = mail_config_get_account_by_source_url (action_data->uri)))
---
> if (account)
153c162
< em_utils_compose_new_message_with_mailto (url, action_data->uri);
---
> em_utils_compose_new_message_with_mailto (url, fromurl);
Index: org-gnome-mailing-list-actions-errors.xml
===================================================================
RCS file: /cvs/gnome/evolution/plugins/mailing-list-actions/org-gnome-mailing-list-actions-errors.xml,v
retrieving revision 1.1
diff -r1.1 org-gnome-mailing-list-actions-errors.xml
16c16
< <secondary>An e-mail message will be sent to the URL "{0}". You can either send the message automatically, or see and change it first.
---
> <secondary>An e-mail message will be sent to the URL "{1}", using the e-mail address "{0}". You can either send the message automatically, or see and change it first.
19,20d18
< <button label="_Send message" response="GTK_RESPONSE_YES"/>
< <button label="_Edit message" response="GTK_RESPONSE_NO"/>
21a20,21
> <button label="_Edit message" response="GTK_RESPONSE_NO"/>
> <button label="_Send message" response="GTK_RESPONSE_YES"/>
Index: org-gnome-mailing-list-actions-errors.xml.h
===================================================================
RCS file: /cvs/gnome/evolution/plugins/mailing-list-actions/org-gnome-mailing-list-actions-errors.xml.h,v
retrieving revision 1.1
diff -r1.1 org-gnome-mailing-list-actions-errors.xml.h
12c12
< char *s = N_("An e-mail message will be sent to the URL \"{0}\". You can either send the message automatically, or see and change it first.\n"
---
> char *s = N_("An e-mail message will be sent to the URL \"{1}\", using the e-mail address \"{0}\". You can either send the message automatically, or see and change it first.\n"
15d14
< char *s = N_("_Send message");
16a16
> char *s = N_("_Send message");
Index: org-gnome-mailing-list-actions.eplug.in
===================================================================
RCS file: /cvs/gnome/evolution/plugins/mailing-list-actions/org-gnome-mailing-list-actions.eplug.in,v
retrieving revision 1.1
diff -r1.1 org-gnome-mailing-list-actions.eplug.in
8,9c8,10
< name="Mailing List Actions plugin"
< description="Provide actions for common mailing list commands (subscribe, unsubscribe, ...)">
---
> name="Mailing List Actions">
> <author name="Meilof Veeningen" email="meilof wanadoo nl"/>
> <description>Provide actions for common mailing list commands such as subscribing, unsubscribing and posting to the mailing list</description>
13,18c14,19
< <item type="item" verb="ListHelp" path="/commands/ListHelp" visible="mailing_list" activate="emla_list_help"/>
< <item type="item" verb="ListSubscribe" path="/commands/ListSubscribe" visible="mailing_list" activate="emla_list_subscribe"/>
< <item type="item" verb="ListUnsubscribe" path="/commands/ListUnsubscribe" visible="mailing_list" activate="emla_list_unsubscribe"/>
< <item type="item" verb="ListPost" path="/commands/ListPost" visible="mailing_list" activate="emla_list_post"/>
< <item type="item" verb="ListOwner" path="/commands/ListOwner" visible="mailing_list" activate="emla_list_owner"/>
< <item type="item" verb="ListArchive" path="/commands/ListArchive" visible="mailing_list" activate="emla_list_archive"/>
---
> <item type="item" verb="ListHelp" path="/commands/ListHelp" enable="mailing_list" activate="emla_list_help"/>
> <item type="item" verb="ListSubscribe" path="/commands/ListSubscribe" enable="mailing_list" activate="emla_list_subscribe"/>
> <item type="item" verb="ListUnsubscribe" path="/commands/ListUnsubscribe" enable="mailing_list" activate="emla_list_unsubscribe"/>
> <item type="item" verb="ListPost" path="/commands/ListPost" enable="mailing_list" activate="emla_list_post"/>
> <item type="item" verb="ListOwner" path="/commands/ListOwner" enable="mailing_list" activate="emla_list_owner"/>
> <item type="item" verb="ListArchive" path="/commands/ListArchive" enable="mailing_list" activate="emla_list_archive"/>
22,27c23,28
< <item type="item" verb="ListHelp" path="/commands/ListHelp" visible="mailing_list" activate="emla_list_help"/>
< <item type="item" verb="ListSubscribe" path="/commands/ListSubscribe" visible="mailing_list" activate="emla_list_subscribe"/>
< <item type="item" verb="ListUnsubscribe" path="/commands/ListUnsubscribe" visible="mailing_list" activate="emla_list_unsubscribe"/>
< <item type="item" verb="ListPost" path="/commands/ListPost" visible="mailing_list" activate="emla_list_post"/>
< <item type="item" verb="ListOwner" path="/commands/ListOwner" visible="mailing_list" activate="emla_list_owner"/>
< <item type="item" verb="ListArchive" path="/commands/ListArchive" visible="mailing_list" activate="emla_list_archive"/>
---
> <item type="item" verb="ListHelp" path="/commands/ListHelp" enable="mailing_list" activate="emla_list_help"/>
> <item type="item" verb="ListSubscribe" path="/commands/ListSubscribe" enable="mailing_list" activate="emla_list_subscribe"/>
> <item type="item" verb="ListUnsubscribe" path="/commands/ListUnsubscribe" enable="mailing_list" activate="emla_list_unsubscribe"/>
> <item type="item" verb="ListPost" path="/commands/ListPost" enable="mailing_list" activate="emla_list_post"/>
> <item type="item" verb="ListOwner" path="/commands/ListOwner" enable="mailing_list" activate="emla_list_owner"/>
> <item type="item" verb="ListArchive" path="/commands/ListArchive" enable="mailing_list" activate="emla_list_archive"/>
31,39c32,39
< <menu id="org.gnome.mail.folderview.popup.select" target="select">
< <item type="bar" path="96.list" visible="mailing_list" activate=""/>
< <item type="submenu" path="96.list.00" visible="mailing_list" activate="" label="Mailing _List"/>
< <item type="item" verb="ListHelp" path="96.list.00/00.help" label="Get list _usage information" visible="mailing_list" activate="emla_list_help"/>
< <item type="item" verb="ListSubscribe" path="96.list.00/10.subscribe" label="_Subscribe to list" visible="mailing_list" activate="emla_list_subscribe"/>
< <item type="item" verb="ListUnsubscribe" path="96.list.00/20.unsubscribe" label="_Un-subscribe to list" visible="mailing_list" activate="emla_list_unsubscribe"/>
< <item type="item" verb="ListPost" path="96.list.00/30.post" label="_Post message to list" visible="mailing_list" activate="emla_list_post"/>
< <item type="item" verb="ListOwner" path="96.list.00/40.owner" label="Contact list _owner" visible="mailing_list" activate="emla_list_owner"/>
< <item type="item" verb="ListArchive" path="96.list.00/50.archive" label="Get list _archive" visible="mailing_list" activate="emla_list_archive"/>
---
> <menu id="org.gnome.evolution.mail.folderview.popup" target="select">
> <item type="submenu" path="20.emfv.50" visible="mailing_list" activate="" label="Mailing _List"/>
> <item type="item" verb="ListHelp" path="20.emfv.50/00.help" label="Get list _usage information" visible="mailing_list" activate="emla_list_help"/>
> <item type="item" verb="ListSubscribe" path="20.emfv.50/10.subscribe" label="_Subscribe to list" visible="mailing_list" activate="emla_list_subscribe"/>
> <item type="item" verb="ListUnsubscribe" path="20.emfv.50/20.unsubscribe" label="_Un-subscribe to list" visible="mailing_list" activate="emla_list_unsubscribe"/>
> <item type="item" verb="ListPost" path="20.emfv.50/30.post" label="_Post message to list" visible="mailing_list" activate="emla_list_post"/>
> <item type="item" verb="ListOwner" path="20.emfv.50/40.owner" label="Contact list _owner" visible="mailing_list" activate="emla_list_owner"/>
> <item type="item" verb="ListArchive" path="20.emfv.50/50.archive" label="Get list _archive" visible="mailing_list" activate="emla_list_archive"/>
Index: org-gnome-mailing-list-actions.xml
===================================================================
RCS file: /cvs/gnome/evolution/plugins/mailing-list-actions/org-gnome-mailing-list-actions.xml,v
retrieving revision 1.1
diff -r1.1 org-gnome-mailing-list-actions.xml
3,8c3,8
< <cmd name="ListHelp" _tip="Get information about the usage of the list this message belongs to"/>
< <cmd name="ListSubscribe" _tip="Subscribe to the mailing list this message belongs to"/>
< <cmd name="ListUnsubscribe" _tip="Unsubscribe to the mailing list this message belongs to"/>
< <cmd name="ListPost" _tip="Post a message to the mailing list this message belongs to"/>
< <cmd name="ListOwner" _tip="Contact the owner of the mailing list this message belongs to"/>
< <cmd name="ListArchive" _tip="Get an archive of the list this message belongs to"/>
---
> <cmd name="ListHelp" _label="Get list _usage information" _tip="Get information about the usage of the list this message belongs to"/>
> <cmd name="ListSubscribe" _label="_Subscribe to list" _tip="Subscribe to the mailing list this message belongs to"/>
> <cmd name="ListUnsubscribe" _label="_Un-subscribe to list" _tip="Unsubscribe to the mailing list this message belongs to"/>
> <cmd name="ListPost" _label="_Post message to list" _tip="Post a message to the mailing list this message belongs to"/>
> <cmd name="ListOwner" _label="Contact list _owner" _tip="Contact the owner of the mailing list this message belongs to"/>
> <cmd name="ListArchive" _label="Get list _archive" _tip="Get an archive of the list this message belongs to"/>
13,20c13,24
< <submenu name="List" _label="Mailing _List">
< <menuitem verb="ListHelp" _label="Get list _usage information"/>
< <menuitem verb="ListSubscribe" _label="_Subscribe to list"/>
< <menuitem verb="ListUnsubscribe" _label="_Un-subscribe to list"/>
< <menuitem verb="ListPost" _label="_Post message to list"/>
< <menuitem verb="ListOwner" _label="Contact list _owner"/>
< <menuitem verb="ListArchive" _label="Get list _archive"/>
< </submenu>
---
> <placeholder name="ComponentActionsPlaceholder">
> <placeholder name="MailMessageActions">
> <submenu name="List" _label="Mailing _List">
> <menuitem name="ListHelp" verb=""/>
> <menuitem name="ListSubscribe" verb=""/>
> <menuitem name="ListUnsubscribe" verb=""/>
> <menuitem name="ListPost" verb=""/>
> <menuitem name="ListOwner" verb=""/>
> <menuitem name="ListArchive" verb=""/>
> </submenu>
> </placeholder>
> </placeholder>
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]
