[evolution-patches] Re: Patch for #68264
- From: Rodrigo Moya <rodrigo novell com>
- To: Diego Sevilla <dsevilla ditec um es>
- Cc: Evolution Patches <evolution-patches lists ximian com>
- Subject: [evolution-patches] Re: Patch for #68264
- Date: Fri, 12 Nov 2004 14:05:55 +0100
On Fri, 2004-11-12 at 13:50 +0100, Diego Sevilla Ruiz wrote:
> Hi all.
>
> Attached is a fix for #68264.
>
> + const char *uri_text = e_source_get_uri (t->source);
>
e_source_get_uri returns a malloc'ed string, so you should not store it
on a const, and you should also g_free it when no longer needed.
> + if (strncmp (uri_text, "file:", 5))
> + return FALSE;
>
this is wrong, it should be if (!strncmp (...
just those 2 changes and the patch will be ok.
--
Rodrigo Moya <rodrigo novell com>
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]