Re: [evolution-patches] auto-focus message list after selecting a folder

[Not Zed <notzed ximian com>]

i dont think this is correct.

how do the other gtktreeview lists in other applications get their (odd) focus behaviour?  That is, a single click changes the selection but doesn't take focus, and then another click will give the focus to it, which wont go away will you move focus elsewhere.

we should be consistent with other gtk apps.  i'm trying to think of an example, but i can't think of one.  perhaps the load selector.

grabbing focus like this below will interfere badly with some behaviour, particularly since it will be invoked in a relatively async manner in some instances.

On Mon, 2004-11-08 at 23:56 -0200, Gustavo Noronha Silva wrote:
> [Please CC: me on replies, I'm not subscribed]
>
> Hi,
>
> I posted a bug on bugzilla[0] and was told to send my patch here. I
> basically want to make my life easier with the keyboard on evolution.
> This is a simple patch to auto-focus the message list when you select
> a folder in the folders list.
>
> By doing this I can use the keyboard most of the time with no need to
> use the mouse to click the message list. Here's the patch:
>
> -------
> --- mail/em-folder-browser.c.old        2004-11-03 02:07:12.000000000 -0200
> +++ mail/em-folder-browser.c    2004-11-03 02:06:33.000000000 -0200
> @@ -857,6 +857,8 @@
>          * e_canvas_item_region_show_relay() uses a timeout, we have to use a timeout of the
>          * same interval but a lower priority. */
>         emfb->priv->idle_scroll_id = g_timeout_add_full (G_PRIORITY_LOW, 250, (GSourceFunc) scroll_idle_cb, emfb, NULL);
> +
> +       gtk_widget_grab_focus (GTK_WIDGET(ml));
>  }
>
>  static void
> -------
>
> I don't really agree with Andre that this should be an option, at least
> not one to be available through the normal UI. Maybe a gconf key is in
> order, but even then I'm not sure. I think this is just a sane default.
>
> Thanks,
>
> [0]: http://bugzilla.ximian.com/show_bug.cgi?id=69048

--

Michael Zucchi <notzed ximian com> "I'm stuck in a reality I can't imagine could be real." Novell's Evolution and Free Software Developer