Re: [evolution-patches] patch for bug #69145

[Jeffrey Stedfast <fejj ximian com>]

I like this fix better too

Jeff

On Sun, 2004-11-07 at 21:59, Not Zed wrote:
> Ok, i don't like this patch, because all its doing is falling back to
> downloading the whole part and thus throwing away almost all the code
> we have there for doing 4rev1 stuff in the first place.  Its just
> hiding some of the many bugs in that code.
> 
> Anyway i've attached a fix for those bugs (or enough to get a test
> case to work), although i haven't tested much beyond this specific
> case.
> 
> What it was doing was fetching the same headers twice, that is,
> fetching "HEADER" when it was supposed to be fetching "1.HEADER" for
> the embedded message.  And then it ended up setting up a "1" part for
> the attachment content rather than "1.TEXT", and thus it shows the
> whole message as text, including the headers.
> 
> Lastly, the contentinfo_incomplete thing was failing since we had a
> partially setup mi->content which had empty children, but not no
> children, so it was considering it complete.
> 
> Michael
> 
> PS i'm not sure it was worth all the effort, but, well its done now.
> 
> On Fri, 2004-11-05 at 12:51 -0500, Jeffrey Stedfast wrote: 
> > http://bugzilla.ximian.com/show_bug.cgi?id=69145
> > 
> > this is a bug that's been sitting in my inbox for a week or 2 now that
> > I've been wrestling with fixing when I get bored hacking on imap4.
> > ;
> -- 
> 
> Michael Zucchi <notzed ximian com>
> "I'm stuck in a reality I can't
> imagine could be real."
> Novell's Evolution and Free
> Software Developer