Re: [evolution-patches] Patch about a11y bugs in addressbook

[Hans Petter Jansson <hpj ximian com>]

On Sun, 2004-10-31 at 19:04 -0800, shenghao wrote:

> Attach is a patch about a11y bug in addressbook part for HEAD.
> It fixes the bug as follow:
> Steps to reproduce:
> 1. Launch GOK and Evolution.
> 2. Ensure there are enough contacts in contacts folder, such as Local
> Contacts Folder.
> 3. Select UI Grab in GOK.
> Bug observation:
> Contacts in contacts folder cannot be grabbed in GOK.
> 
> Please Would you like to spend a little time to review it, please?

In ea-minicard-view.c, don't use MINICARD_VIEW_ACTION_NUM to count the
elements in the array. Use G_N_ELEMENTS (action_name) whenever you need
the count.

Same in ea-minicard.c.

In ea_minicard_get_name(), leave the #define in the first column (no
space before the #), and remove the blank line before the first variable
declaration.

What does the removed chunk of code in ea_minicard_get_name() do?

In atk_action_interface_do_action() in ea-minicard.c, there's a call to
activiate_editor(). I assume this should be activate_editor()? I.e.
without the 'i' thrown in. Same for the declaration in e-minicard.c. It
looks like this typo was there already - I don't mind if you correct it
in this patch. Or you can leave it alone, if you wish.

You're also making activiate_editor() be a public function - when doing
so, it's necessary to namespace it - add e_minicard_ before it, so it
doesn't clash with other declarations. I.e.
e_minicard_activate_editor().

You also change a lot of spacing unnecessarily, but I can live with
that. Try to avoid it in the future, it makes patches harder to review.

Please make these changes and repost the patch. Thanks!

-- 
Hans Petter Jansson | <hpj novell com>
Evolution Developer | http://hp.cl.no/