Re: [evolution-patches] Patch about a11y bugs in widgets directory



As agreed in IRC, patch committed into CVS with removing the NULL judgement of  gtk_widget_get_accessible().
Thanks for the review.
    Harry

JP Rosevear wrote:
On Thu, 2004-10-28 at 12:31 +0800, Li Yuan wrote:
  
Also, why do we check for a non-null a11y object?  The gtk color
selector

Its usual not to wrap a single statement in {}.
 

        
I removed the {}, but i think gtk_widget_get_accessible may return 
NULL here.
      

Not if I read the code right in gtkwidget.c.  It tries to find an
existing accessibility object, and if it can't it creates one.

-JP
  


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]