Re: [evolution-patches] patch to fix bug #59158: new vfolder does not take effect

[Not Zed <notzed ximian com>]

On Fri, 2004-05-28 at 12:33 -0700, Bruce Tao wrote:
> Ok, michael, thx for your review.
> I think you are right. But in the "rule_changed" func why it checks the 
> rule->source ?
I don't know.  I think that might be the bug.  I think rule_changed should be checking rule->with != VFOLDER_RULE_WITH_SPECIFIC.

And mail_vfolder_add_uri, i dont think it should be checking rule->source either - at all.

> Is it a mistake or concerned with some other functionalities ?
> Besides, in the "vfolders.xml", there do exists "source" element. I 
> wonder what it's about.
The source element in vfolders and searches, which share common code, is to specify a system vs user rule, in that case.  Its not used for vfolders.