Re: [evolution-patches] patch for uri related changes to groupwise cal backend

[Rodrigo Moya <rodrigo ximian com>]

On Tue, 2004-05-25 at 16:08 +0530, Sivaiah N wrote:
> Hi,
> The attached pathc the changes i did groupwise calendar backend to
> incorporate the change in uri format which was changed to make the all
> components share the remembered password.


> +               port = e_source_get_property (source, "port");
> +       if (port == NULL)
> +               port = "7181";
> +
> +               formed_uri = g_strconcat ("http://";, parsed_uri-
> >host,":", port, "/soap", NULL );
> 
the ideal thing here would be to have a e_uri_set_port.

> -       /* convert the URI */
> -       vuri = convert_uri (e_cal_backend_get_uri (E_CAL_BACKEND
> (cbgw)));
> -       if (!vuri) {
> 
convert_uri needs to go away if it's not used anymore.

the rest looks ok.

cheers