Re: [evolution-patches] resubmitting eds proxy patch

[Rodrigo Moya <rodrigo ximian com>]

On Tue, 2004-05-18 at 18:19 +0200, Jens Reimann wrote:
> hi,
> 
> here is the eds proxy patch again. including the suggested changed from
> dan winship.
> 
> 
> +       if ( uri )
> +               uri_string = soup_uri_to_string ( uri, FALSE );
> 
this check is redundant, since you have created 'uri' some lines above.

> +       if ( uri_string ) {
> +               g_message ( "Proxy URI: %s\n", uri_string );
>
use g_message (G_STRLOC "Proxy...") for debug messages.

> +       if ( conf_client )
> +               g_object_unref ( conf_client );
> 
this one is also redundant, you got the conf_client above, and you
checked already for it not being NULL.

> +static void
> +update_proxy ( ECalBackendHttp *cbhttp )
> +{
> +       if ( !cbhttp ) return;
> +       if ( !cbhttp->priv ) return;
> +       if ( !cbhttp->priv->soup_session ) return;
> 
this does not follow evolution coding guidelines. The return statement
must be in its own line.

> +       if ( proxy_uri ) {
> +               soup_session = soup_session_async_new_with_options
> ( SOUP_SESSION_PROXY_URI, proxy_uri, NULL );
> +       } else {
> +               soup_session = soup_session_async_new ();
> +       }
> +
> +       if ( proxy_uri )
> +               soup_uri_free ( proxy_uri );
> 
again, redundant checks, just call soup_uri_free after the 'soup_session
= ..." line.

cheers