Re: [evolution-patches] eds proxy patch

[Dan Winship <danw novell com>]

On Mon, 2004-05-17 at 09:09 +0200, Jens Reimann wrote:
> a proxy (usign gconf) patch for eds http calendar backend

a few notes...

> +       /* create a dummy object */
> +       uri = soup_uri_new ( "http://localhost"; );
> +
> +       if ( uri->host )
> +               g_free ( uri->host );

This seems a little ugly. You're allowed to just create the SoupUri by
hand:

	uri = g_new0 (SoupUri, 1);
	uri->protocol = SOUP_PROTOCOL_HTTP;

Likewise, the code in assign_new_proxy doesn't need to fiddle with
GValues directly. Just do

	g_object_set (G_OBJECT (session),
		      SOUP_SESSION_PROXY_URI, uri,
		      NULL);

-- Dan