[evolution-patches] Patch for 57564: reminder message option for appointments
- From: Nicel KM <mnicel novell com>
- To: evolution-patches lists ximian com
- Subject: [evolution-patches] Patch for 57564: reminder message option for appointments
- Date: Fri, 14 May 2004 14:13:30 +0530
Hi Rodrigo,
Thanks for your checkin. It requires a similar check in
button_options_clicked_cb() so that the options dialog is invoked even
if email alarms are not supported by backend. Attached patch adds this
check. Please let me know if it's ok.
Fixes #57564
regards,
-Nicel.
PS: also, do we really need the alarm_email_address in this options
dialog otherwise?
Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/evolution/calendar/ChangeLog,v
retrieving revision 1.2320
diff -u -r1.2320 ChangeLog
--- ChangeLog 13 May 2004 15:31:24 -0000 1.2320
+++ ChangeLog 14 May 2004 08:28:04 -0000
@@ -1,3 +1,9 @@
+2004-05-14 Nicel KM <mnicel novell com>
+
+ * gui/dialogs/alarm-page.c (button_options_clicked_cb): invoke options
+ dialog even if backend does not support email alarms and get email
+ address only if supported.
+
2004-05-13 Rodrigo Moya <rodrigo ximian com>
* gui/dialogs/alarm-page.c (add_clicked_cb): only get the email address
Index: gui/dialogs/alarm-page.c
===================================================================
RCS file: /cvs/gnome/evolution/calendar/gui/dialogs/alarm-page.c,v
retrieving revision 1.41
diff -u -r1.41 alarm-page.c
--- gui/dialogs/alarm-page.c 13 May 2004 15:31:24 -0000 1.41
+++ gui/dialogs/alarm-page.c 14 May 2004 08:28:04 -0000
@@ -755,7 +755,8 @@
repeat = !e_cal_get_static_capability (COMP_EDITOR_PAGE (apage)->client,
CAL_STATIC_CAPABILITY_NO_ALARM_REPEAT);
- if (e_cal_get_alarm_email_address (COMP_EDITOR_PAGE (apage)->client, &email, NULL)) {
+ if (e_cal_get_static_capability (COMP_EDITOR_PAGE (apage)->client, CAL_STATIC_CAPABILITY_NO_EMAIL_ALARMS)
+ || e_cal_get_alarm_email_address (COMP_EDITOR_PAGE (apage)->client, &email, NULL)) {
if (!alarm_options_dialog_run (priv->alarm, email, repeat))
g_message ("button_options_clicked_cb(): Could not create the alarm options dialog");
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]