Re: [evolution-patches] Fix for adding the SAVE_SCHEDULE static capability for GW

[Rodrigo Moya <rodrigo ximian com>]

On Tue, 2004-05-04 at 19:34 +0530, Harish Krishnaswamy wrote:
> hi, 
> 
> the patch contains minor fixes for 3 issues -
> 
> i) adding static capability CAL_STATIC_CAPABILITY_SAVE_SCHEDULES for GW
> backend .
> ii) add message to view element to enable message bodies to be received
> from the server as plain text.
> iii) set Calendar as the Task folder source -not  Checklist
> 
> kindly review the same..
> 
> harish
> 
> Index: calendar/ChangeLog
> ===================================================================
> RCS file: /cvs/gnome/evolution-data-server/calendar/ChangeLog,v
> retrieving revision 1.255
> diff -u -p -r1.255 ChangeLog
> --- calendar/ChangeLog	4 May 2004 05:47:41 -0000	1.255
> +++ calendar/ChangeLog	4 May 2004 13:58:49 -0000
> @@ -1,3 +1,15 @@
> +2004-05-05  Harish Krishnaswamy  <kharish novell com>
> +
> +	* libecal/e-cal.c: (load_static_capabilities): assign capabilities
> +	to ecal->capabilities so that it need not be computed repeatedly.
> +	* backends/groupwise/e-cal-backend-groupwise.c: 
> +	(populate_cache) : added message to view element to recieve 
> +	message bodies as plain text (default).
> +	(connect_to_server) : the Tasks folder is also Calendar and 
> +	not Checklist in GW server.
> +	(e_cal_backend_groupwise_get_static_capabilities) :
> +	Added CAL_STATIC_CAPABILITY_SAVE_SCHEDULES.
> +
>  2004-05-04  Harish Krishnaswamy  <kharish novell com>
>  
>  	* backends/groupwise/e-cal-backend-groupwise-utils.c:
> Index: calendar/libecal/e-cal.c
> ===================================================================
> RCS file: /cvs/gnome/evolution-data-server/calendar/libecal/e-cal.c,v
> retrieving revision 1.58
> diff -u -p -r1.58 e-cal.c
> --- calendar/libecal/e-cal.c	3 May 2004 14:13:55 -0000	1.58
> +++ calendar/libecal/e-cal.c	4 May 2004 13:58:50 -0000
> @@ -2200,7 +2200,7 @@ load_static_capabilities (ECal *ecal, GE
>  	g_cond_wait (our_op->cond, our_op->mutex);
>  
>  	status = our_op->status;
> -	cap = our_op->string;
> +	priv->capabilities = our_op->string;
>  	
>  	e_calendar_remove_op (ecal, our_op);
>  	g_mutex_unlock (our_op->mutex);
> Index: calendar/backends/groupwise/e-cal-backend-groupwise.c
> ===================================================================
> RCS file:
> /cvs/gnome/evolution-data-server/calendar/backends/groupwise/e-cal-backend-groupwise.c,v
> retrieving revision 1.65
> diff -u -p -r1.65 e-cal-backend-groupwise.c
> --- calendar/backends/groupwise/e-cal-backend-groupwise.c	8 Apr 2004
> 14:18:32 -0000	1.65
> +++ calendar/backends/groupwise/e-cal-backend-groupwise.c	4 May 2004
> 13:58:50 -0000
> @@ -79,7 +79,7 @@ populate_cache (ECalBackendGroupwise *cb
>  	priv = cbgw->priv;
>  
>          /* get all the objects from the server */
> -        status = e_gw_connection_get_items (priv->cnc,
> priv->container_id, "recipients", NULL, &list);
> +        status = e_gw_connection_get_items (priv->cnc,
> priv->container_id, "recipients message", NULL, &list);
>          if (status != E_GW_CONNECTION_STATUS_OK) {
>                  g_list_free (list);
>  		e_cal_backend_groupwise_notify_error_code (cbgw, status);
> @@ -223,8 +223,8 @@ connect_to_server (ECalBackendGroupwise 
>  				priv->container_id = e_gw_connection_get_container_id (priv->cnc,
> "Calendar");
>  				e_source_set_name (e_cal_backend_get_source (E_CAL_BACKEND (cbgw)),
> _("Calendar"));
>  			} else if (kind == ICAL_VTODO_COMPONENT) {
> -				priv->container_id = e_gw_connection_get_container_id (priv->cnc,
> "Checklist");
> -				e_source_set_name (e_cal_backend_get_source (E_CAL_BACKEND (cbgw)),
> _("Checklist"));
> +				priv->container_id = e_gw_connection_get_container_id (priv->cnc,
> "Calendar");
> +				e_source_set_name (e_cal_backend_get_source (E_CAL_BACKEND (cbgw)),
> _("Calendar"));
>
I think this line can be removed, since it's got no effect at all to set
the name on the source.

apart from that, it looks ok

cheers