Re: [evolution-patches] Bug 53466: Typos and unclear messages in Evolution

[Not Zed <notzed ximian com>]

On Mon, 2004-05-03 at 23:09 -0700, davef d2 com wrote:
> Attached are several patches, and some questions.
>
> The first one, typos.patch, should be straightforward - some spelling
> fixes, basically.
first mail ones look ok.

> The second one. from-account.patch, slightly more involved - I changed:
> "Cannot sign outgoing message: No signing certificate set for from account"
>
> to
> "Cannot sign outgoing message: No signing certificate set for account
> message is from"
>
> but, that may not be best either. Will further send questions/patches
> along as I have a chance.

I like this less.  The message isn't from any account, yet it is the from account which is wrong.  The current message is more accurate and easier to understand.  It is the "from account" which is wrong, its not "the account from which this message comes" - its a new message.

since those errors aren't really exceptions, they're just used to pass it to a central error routine, they should probably be made their own proper hig error using e_error.  that way more detail can be added as well.

>

Michael Zucchi <notzed ximian com> Ximian Evolution and Free Software Developer

Novell, Inc.