Re: [evolution-patches] add missing labels to dock items

[William Jon McCann <mccannwj pha jhu edu>]

Rodrigo Moya wrote:
> On Wed, 2004-03-31 at 01:06 -0500, William Jon McCann wrote:
>
>
> > Hi,
> >
> > Here is a patch that adds missing labels to calendar and task dock items.
> >
> > Please let me know if this is ok.
>
>
> hmm, does this make those labels show up next to the icon on the
> menu/toolbar items? Because, I think we don't want that for those items,
> and so, what's the point of having those labels?
>
> cheers


These labels should not show up when the GNOME Menus & Toolbars 
preference is set to Text Beside Icons because the priority attribute is 
not set on these toolitems.  I am not going to advocate setting the 
priority attribute.

However, I think we really do want the labels.  For at least these few 
reasons:

 (App Consistency)
 - all the other toolbar items in tasks & cal have them
 - the equivalent tools in the other evo components (delete, print, 
etc.) have labels

 (GNOME Consistency)
 - you must show labels when Toolbar pref is set to Text only
 - you should show labels when Toolbar pref is set to Text Below Icons

 (HIG)
 - increases target area
 - self describing action : important when icon theme is unusual. 
Imagine a theme that uses a Home icon that looks like a doormat.  What 
would that do?

I'll hold off committing...

Jon