Re: [evolution-patches] cancel_component_dialog problem

["alfred.peng" <alfred peng sun com>]

Dear JP Rosevear,

   Thanks for your explanation.

   But in the source file 
calendar/gui/dialogs/send-comp.c(send_component_dialog) & 
calendar/gui/dialogs/cancel-comp.c(cancel_component_dialog), when we set 
the "CAL_STATIC_CAPABILITY_SAVE_SCHEDULES" sign, the return value of 
these two function are different.
   That's to say, when we cancel a event, sending a message to the 
attendees is the default action; But when we make a change to a event, 
no message sending is the default action.
   Why are they different? Or we should make them consistent?

   Patch forgotten. Resend it.

Best regards
Alfred Peng

JP Rosevear wrote:

> On Sun, 2004-03-21 at 02:59, alfred.peng wrote:
>  
>
> > Dear Rodrigo,
> >
> > Would you please give me some advices?
> >
> > Maybe this inconsistency has some influence on our SUN backend
> > implementation.
> >    
>
> I believe this was put in because of the SunONE backend.  The sunone
> backend does scheduling itself as soon as the item is saved.  This check
> ensures just skips giving the dialog to the user when cancelling because
> if the item is being deleted it must be cancelled on the server.
>
> -JP
>  

Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/evolution/calendar/ChangeLog,v
retrieving revision 1.2219
diff -u -r1.2219 ChangeLog
--- ChangeLog	26 Mar 2004 21:08:30 -0000	1.2219
+++ ChangeLog	29 Mar 2004 09:19:11 -0000
@@ -1,3 +1,9 @@
+2004-03-29  Alfred Peng <alfred peng sun com>
+
+	* gui/dialogs/cancel-comp.c (cancel_component_dialog): when the
+	flag "CAL_STATIC_CAPABILITY_SAVE_SCHEDULES" is set and a meeting
+	apointment is canceled, don't send the message to the attendees.
+	
 2004-03-26  JP Rosevear <jpr ximian com>
 
 	* gui/e-cal-model.c (update_e_cal_view_for_client): guard against
Index: gui/dialogs/cancel-comp.c
===================================================================
RCS file: /cvs/gnome/evolution/calendar/gui/dialogs/cancel-comp.c,v
retrieving revision 1.11
diff -u -r1.11 cancel-comp.c
--- gui/dialogs/cancel-comp.c	12 Jan 2004 21:19:09 -0000	1.11
+++ gui/dialogs/cancel-comp.c	29 Mar 2004 09:19:11 -0000
@@ -47,7 +47,7 @@
 	gint response;
 
 	if (deleting && e_cal_get_save_schedules (client))
-		return TRUE;
+		return FALSE;
 
 	vtype = e_cal_component_get_vtype (comp);