[evolution-patches] probable fix for 55527



hpj and I found this a few nights ago, and I've been running with the
change and haven't seen the crashes at all for a few days now.  I'd
forgotten making the change and was actually getting pretty frustrated
that I couldn't reproduce it anymore.  heh.

Michael tried it and it looks like it fixed it for him as well, although
it hasn't seen as much testing on his machine.

Regardless of whether or not it fixes the bug, it should go in as the
corresponding unref is a call to bonobo_object_release_unref.

Chris
Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/evolution-data-server/addressbook/ChangeLog,v
retrieving revision 1.108
diff -u -r1.108 ChangeLog
--- ChangeLog	20 Mar 2004 02:22:15 -0000	1.108
+++ ChangeLog	26 Mar 2004 05:59:09 -0000
@@ -1,3 +1,9 @@
+2004-03-25  Chris Toshok  <toshok ximian com>
+
+	[ looks like this fixes #55527 ]
+	* libedata-book/e-data-book-view.c (e_data_book_view_construct):
+	use bonobo_object_dup_ref instead of CORBA_Object_duplicate here.
+
 2004-03-19  Chris Toshok  <toshok ximian com>
 
 	* libebook/e-book-view-listener.c (main_thread_get_response):
Index: libedata-book/e-data-book-view.c
===================================================================
RCS file: /cvs/gnome/evolution-data-server/addressbook/libedata-book/e-data-book-view.c,v
retrieving revision 1.5
diff -u -r1.5 e-data-book-view.c
--- libedata-book/e-data-book-view.c	13 Mar 2004 22:40:44 -0000	1.5
+++ libedata-book/e-data-book-view.c	26 Mar 2004 05:59:09 -0000
@@ -334,7 +334,7 @@
 
 	CORBA_exception_init (&ev);
 
-	priv->listener = CORBA_Object_duplicate (listener, &ev);
+	priv->listener = bonobo_object_dup_ref (listener, &ev);
 	if (ev._major != CORBA_NO_EXCEPTION) {
 		g_warning("Unable to duplicate listener object in pas-book-view.c\n");
 		CORBA_exception_free (&ev);


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]