Re: [evolution-patches] sending email problem

["alfred.peng" <alfred peng sun com>]

A new patch with ChangeLog

On Mon, 2004-03-22 at 17:55, Rodrigo Moya wrote:
> On Mon, 2004-03-22 at 16:02 +0800, alfred.peng wrote:
> 
> > Dear Rogrigo,
> >    I found a problem on the email delivery. Would you please help me to
> > check it?
> > 
> >    When I create a new appointment and make a email alarm for it, the
> > sending message doesn't deliver to the server backend.
> >    Stepping into the source code, I found a problem in file
> > gui/dialogs/alarm-options.c(malarm_widgets_to_alarm). When filling the
> > mail alarm data with the values from the widgets, we get the description
> > message from dialog->dalarm_description instead of
> > dialog->malarm_description.
> >    I think this maybe the problem, so I give a patch for it.
> > 
> yes, seems to look ok, but are you sure it works correctly after
> applying your patch?
> 
> Also, you're missing a ChangeLog entry.
> 
> cheers
> 
> _______________________________________________
> Evolution-patches mailing list
> Evolution-patches lists ximian com
> http://lists.ximian.com/mailman/listinfo/evolution-patches

Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/evolution/calendar/ChangeLog,v
retrieving revision 1.2201
diff -u -r1.2201 ChangeLog
--- ChangeLog	19 Mar 2004 17:03:26 -0000	1.2201
+++ ChangeLog	22 Mar 2004 10:20:26 -0000
@@ -1,3 +1,9 @@
+2004-03-22  Alfred Peng <alfred peng sun com>
+
+	* gui/dialogs/alarm-options.c (malarm_widgets_to_alarm): get
+	the mail alarm description message from "malarm_description"
+	instead of "dalarm_description".
+
 2004-03-19  JP Rosevear  <jpr ximian com>
 
 	Fixes #55716
Index: gui/dialogs/alarm-options.c
===================================================================
RCS file: /cvs/gnome/evolution/calendar/gui/dialogs/alarm-options.c,v
retrieving revision 1.22
diff -u -r1.22 alarm-options.c
--- gui/dialogs/alarm-options.c	1 Dec 2003 22:14:25 -0000	1.22
+++ gui/dialogs/alarm-options.c	22 Mar 2004 10:20:26 -0000
@@ -649,7 +649,7 @@
 	eab_destination_freev (destv);	
 
 	/* Description */
-	text_buffer = gtk_text_view_get_buffer (GTK_TEXT_VIEW (dialog->dalarm_description));
+	text_buffer = gtk_text_view_get_buffer (GTK_TEXT_VIEW (dialog->malarm_description));
 	gtk_text_buffer_get_start_iter (text_buffer, &text_iter_start);
 	gtk_text_buffer_get_end_iter   (text_buffer, &text_iter_end);
 	str = gtk_text_buffer_get_text (text_buffer, &text_iter_start, &text_iter_end, FALSE);