Re: [despammed] Re: [evolution-patches] Patch for -> 53653 (Esc key does not close move/copy contact to dialog)

["Pratik V. Parikh" <pratikvp despammed com>]

On Mon, 22 Mar 2004 11:53:32 +0800, "Not Zed" <notzed ximian com> said:
> 
> Hi,
> 
> Although i'm not the contact maintainer, i know in the mailer we fixed
> this issue by changing lines such as:
> 
>   cancel_button = gtk_dialog_add_button (GTK_DIALOG (dialog),
> GTK_STOCK_CA
> NCEL, GTK_RESPONSE_REJECT);
> 
> to use GTK_RESPONSE_CANCEL instead.  GtkDialog will then automatically
> cancel it it when you hit escape, without having to explictly check the
> key yourself.

Oh! yes :$

Attached another patch.
 
Index: addressbook/ChangeLog
===================================================================
RCS file: /cvs/gnome/evolution/addressbook/ChangeLog,v
retrieving revision 1.1615
diff -u -3 -p -u -r1.1615 ChangeLog
--- addressbook/ChangeLog       18 Mar 2004 00:59:11 -0000      1.1615
+++ addressbook/ChangeLog       22 Mar 2004 11:48:13 -0000
@@ -1,3 +1,10 @@
+2004-03-22  Pratik V. Parikh <pratikvp despammed com>
+
+       Fixes #53653
+
+       * /gui/widgets/eab-gui-util.c (eab_select_source) : Close
move/copy 
+       dialog when ESC is pressed.
+
 2004-03-17  Hans Petter Jansson  <hpj ximian com>
 
 	Fixes #53625.
Index: addressbook/gui/widgets/eab-gui-util.c
===================================================================
RCS file: /cvs/gnome/evolution/addressbook/gui/widgets/eab-gui-util.c,v
retrieving revision 1.8
diff -u -3 -p -u -r1.8 eab-gui-util.c
--- addressbook/gui/widgets/eab-gui-util.c      11 Feb 2004 20:29:33
-0000      1.8
+++ addressbook/gui/widgets/eab-gui-util.c      22 Mar 2004 11:48:15
-0000
@@ -351,7 +351,7 @@ eab_select_source (const gchar *title, c
 					      NULL);
 	gtk_window_set_default_size (GTK_WINDOW (dialog), 200, 350);
 
-       cancel_button = gtk_dialog_add_button (GTK_DIALOG (dialog),
GTK_STOCK_CANCEL, GTK_RESPONSE_REJECT);
+       cancel_button = gtk_dialog_add_button (GTK_DIALOG (dialog),
GTK_STOCK_CANCEL, GTK_RESPONSE_CANCEL);
 	ok_button = gtk_dialog_add_button (GTK_DIALOG (dialog), GTK_STOCK_OK, GTK_RESPONSE_ACCEPT);
 	gtk_widget_set_sensitive (ok_button, FALSE);

-- 
http://www.fastmail.fm - A no graphics, no pop-ups email service