Re: [evolution-patches] 55389

[JP Rosevear <jpr ximian com>]

On Thu, 2004-03-11 at 07:33, Rodrigo Moya wrote:
> On Wed, 2004-03-10 at 15:12 -0500, JP Rosevear wrote:
> 
> > On Wed, 2004-03-10 at 10:59, Rodrigo Moya wrote:
> > > On Wed, 2004-03-10 at 10:42 -0500, JP Rosevear wrote:
> > > 
> > > > On Wed, 2004-03-10 at 07:07, Rodrigo Moya wrote:
> > > > > On Tue, 2004-03-09 at 18:52 -0500, JP Rosevear wrote:
> > > > > 
> > > > > hmm, I thought send_objects should return only the objects it modified.
> > > > > If that's not the case, the patch looks ok.
> > > > 
> > > > Committed.
> > > > 
> > > the same patch but for the contacts and http backends.
> > 
> > I think you don't need to do it for those two because they are both read
> > only and hence should return an error code like the http one does.  
> > 
> > We should however guard against NULL in notify routine so that if there
> > is an error we don't try to send back a NULL via CORBA.
> > 
> right, attached patch fixes both of them.

Approved.

-JP
-- 
JP Rosevear <jpr ximian com>
Ximian, Inc.