Re: [evolution-patches] merging e-d-s gw address book branch with HEAD

[Sivaiah N <snallagatla novell com>]

Branch is merged into HEAD 
Thanks,
Sivaiah
On Wed, 2004-03-10 at 21:05, Rodrigo Moya wrote:
> On Wed, 2004-03-10 at 19:18 +0530, Sivaiah N wrote:
> 
> > Hi,
> > I have been working on groupwise-addressbook-backend branch for
> > developing groupwise address backend. Now it is ready for to be merged
> > into HEAD. The following are the files which are modified or added in
> > the branch.
> > 
> > M ChangeLog
> > M configure.in
> > M addressbook/ChangeLog
> > M addressbook/backends/Makefile.am
> > A addressbook/backends/groupwise/Makefile.am
> > A addressbook/backends/groupwise/create-account.c
> > A addressbook/backends/groupwise/e-book-backend-groupwise.c
> > A addressbook/backends/groupwise/e-book-backend-groupwise.h
> > M servers/groupwise/ChangeLog
> > M servers/groupwise/Makefile.am
> > M servers/groupwise/e-gw-connection.c
> > M servers/groupwise/e-gw-connection.h
> > M servers/groupwise/e-gw-container.c
> > M servers/groupwise/e-gw-container.h
> > A servers/groupwise/e-gw-filter.c
> > A servers/groupwise/e-gw-filter.h
> > M servers/groupwise/e-gw-item.c
> > M servers/groupwise/e-gw-item.h
> > M servers/groupwise/e-gw-message.c
> > M servers/groupwise/e-gw-message.h
> > M src/GNOME_Evolution_DataServerLDAP.server.in.in
> > M src/GNOME_Evolution_DataServerNOLDAP.server.in.in
> > M src/Makefile.am
> > M src/server.c
> > 
> > I have attached    three diff files which are as follows.
> > (i) common_classes.diff has changes and additions done under
> > server/groupwise dir
> >  (ii) backend.diff has addtions made  under
> > addresbook/backends/groupwise
> > (iii) Other.diff has changes made to configure.in and under src/ dir 
> > 
> > These changes are already sent as patches to evo-patches earlier.
> > 
> I'd say commit, and after that, send patches for all the needed changes.
> To start with, some comments below:
> 
> > +void e_gw_message_write_string_parameter_with_attribute (SoupSoapMessage *msg, const char *name, const char *prefix, const char *value, 
> > +							 char *attrubute_name, char*attribute_value);
> > +
> I suggested in a previous mail having this function be called .._with_attributes, and
> accept a variable list of attribute name/value pairs.
> 
> > +/* structures defined to hold contact item fields */
> > +typedef struct {
> > +	char *name_prefix;
> > +	char *first_name;
> > +	char *middle_name;
> > +	char *last_name;
> > +	char *name_suffix;
> > +} FullName;
> > +
> > +typedef struct {
> > +	char *street_address;
> > +	char *location;
> > +	char *city;
> > +	char *state;
> > +	char *postal_code;
> > +	char *country;
> > +} PostalAddress;
> > +
> > +typedef struct {
> > +
> > +	char *service;
> > +	char *address;
> > +}IMAddress;
> > 
> if those structs are in a public header file, they should have a EGw prefix.
> 
> Apart from that, it looks you've got a lot of weird formatting all over, with extra
> blank lines.
> 
> cheers
>