Committed with if/else statement instead of ?:. -- dobey On Mër , 2004-03-10 at 01:40, Chris Toshok wrote: > + contacts_path = strcmp (strrchr (contacts_uri, '/') + 1, > "addressbook.db") == 0 ? g_dirname (contacts_uri) : g_strdup > (contacts_uri); > > I'd rather see that done as an if/else than the ?: conditional, but > other than that the patch looks fine and dandy. > > Chris > > On Tue, 2004-03-09 at 11:28, Rodney Dawes wrote: > > OK. New patch again, this time with correct function calls for g_free. > > > > -- dobey > > > > On Mar , 2004-03-09 at 09:21, Rodney Dawes wrote: > > > Doh. Forgot to cc: toshok. Dude? :) > > > > > > On Hën , 2004-03-08 at 18:01, Rodney Dawes wrote: > > > > In testing 1.4.6, it was discovered that the select names dialog doesn't > > > > correctly load the default folder, if no other folder was opened > > > > previously using the folder selector button. The following patch fixes > > > > the issue, by checking that the URI is not an empty string, as well as > > > > not being NULL. It also passes the correct version of the URI to the > > > > folder selector button, so the label and icon are set correctly (it > > > > strips off the /addressbook.db). It also switches to using the standard > > > > e_config_listener_get_string () instead of _with_default (), since we > > > > are just passing NULL as the default anyway. > > > > > > > > -- dobey > > > >
Attachment:
signature.asc
Description: This is a digitally signed message part