Re: [evolution-patches] composer/ change discard message when closing unsaved messaged to include untitled message

[Not Zed <notzed ximian com>]

Jeff, you really should've helped Trent fix his version, or at least
given him some credit for him in the ChangeLog for suggesting the fix!

On Sun, 2004-03-07 at 10:09 -0500, Jeffrey Stedfast wrote:

> A couple things:
> 
> - use g_strdup/g_free rather than strdup/free
> - i18n'ise your strings ->  _("Untitled Message")
> - follow the coding style/formatting:
> 
> If there is only one statement in the if-resolution, then don't use
> brackets
> 
> if (foo)
>    bar;
> 
> since the rest of the code in that function puts a space between the
> function name and the (, you should too.
> 
> As it turns out, you also had no need to strdup the subject. It could
> just as easily be done with the attached patch.
> 
> FWIW, I've committed my version of th patch to CVS.
> 
> Thanks for the patch,
> 
> Jeff
> 
> On Sun, 2004-03-07 at 09:35, Trent Lloyd wrote: 
> > Hi,
> > 
> > this small patch addresses the following issues
> > 
> >  * Changes the discard dialogs (if your closing an unsaved message in
> >  * composer) to say "Untitled Message" rather than "" for messages
> >  * without a subject.
> > 
> > I think this is a bit nicer than just having "" there.
> > 
> > Cheers,
> > Trent
> > Sixlabs
> 
> 
> 
> -- 
> Jeffrey Stedfast
> Evolution Hacker - Ximian, Inc.
> fejj ximian com  - www.ximian.com