Re: [evolution-patches] Re: Prettify folder property dialog

[Not Zed <notzed ximian com>]

"Total message: 1"

sounds kinda wrong.

"Total messages: 1"

is still correct isn't it, for english?  It is a label, not a sentence.

"1 message total"
"2 messages total"

is quite a different beast.

e.g.
"I have 1 apple", "I have 2 apples"
vs
"How many apples to I have?  I have 1 apple."
not
"How many apple do I have?  I have 1 apple."

On Wed, 2004-06-16 at 17:47 -0400, Rodney Dawes wrote:
> Hi,
>
> I took your second revision of this patch, and cleaned it up to not be
> redundant between the folder name label and the dialog title, as well as
> to look a little more HIG compliant by using a bold label of the
> folder's name as the group label, and making the message counts be as
> children of that group. I also added a cancel button, since the fact
> that indexing a folder could take hours, means that it should not be
> instant apply, and things that aren't instant apply, should have a
> cancel button.
Ugh, thats bloody weird.
> The ngettext() call for the unread messages string, was also wrong, as
> you were passing the total number of messages, not the total number of
> unread messages. I also think the label for singular there should be
> "Unread messages:" instead of "Unread message:" but am also inclined to
> think that we should get rid of the redundant use of "messages" there,
> since "Unread:" is obvious enough.
>
> There was also a typo in a previous patch from you for mail-component.c
> it seems. I fixed that as well.
>
> What I have committed, is attached.
>
> -- dobey

--

Michael Zucchi <notzed ximian com> Ximian Evolution and Free Software Developer