[evolution-patches] patch for contact-editor



Hi,
Currently when full name is modified by clicking using  full name window
by clicking on full name button, the OK button of contact editor does
not get enabled. This is because the modified name is set in the entry
using set_entry_text which blocks the changed signal and hence prevents
OK button from being enabled
Attached small patch fixes this .

Thanks,
Siva
Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/evolution/addressbook/ChangeLog,v
retrieving revision 1.1755
diff -u -r1.1755 ChangeLog
--- ChangeLog	14 Jun 2004 19:12:47 -0000	1.1755
+++ ChangeLog	15 Jun 2004 13:18:49 -0000
@@ -1,3 +1,11 @@
+2004-06-15  Sivaiah Nallagatla <snallagatla novell com>
+	
+	* gui/contact-editor/e-contact-editor.c (full_name_clicked) :
+	compare old and new full names and if it is different set the new 
+	the name using gtk_entry_set_text instead of set_entry_text
+	as this function blocks siganls hence preventing ok button being 
+	enabled
+
 2004-06-14  Chris Toshok  <toshok ximian com>
 
 	* gui/contact-editor/e-contact-editor.c (extract_im_record): set
Index: gui/contact-editor/e-contact-editor.c
===================================================================
RCS file: /cvs/gnome/evolution/addressbook/gui/contact-editor/e-contact-editor.c,v
retrieving revision 1.204
diff -u -r1.204 e-contact-editor.c
--- gui/contact-editor/e-contact-editor.c	14 Jun 2004 19:12:48 -0000	1.204
+++ gui/contact-editor/e-contact-editor.c	15 Jun 2004 13:18:50 -0000
@@ -2317,7 +2317,10 @@
 		fname_widget = glade_xml_get_widget(editor->gui, "entry-fullname");
 		if (fname_widget && GTK_IS_ENTRY (fname_widget)) {
 			char *full_name = e_contact_name_to_string(name);
-			set_entry_text (editor, GTK_ENTRY (fname_widget), full_name);
+			char *old_full_name = gtk_entry_get_text (GTK_ENTRY(fname_widget));
+
+			if (strcmp (full_name, old_full_name))
+				gtk_entry_set_text (GTK_ENTRY (fname_widget), full_name);
 			g_free(full_name);
 		}
 


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]