Re: [evolution-patches] e-error border width fix

[Not Zed <notzed ximian com>]

On Thu, 2004-06-03 at 23:19 -0400, Rodney Dawes wrote:
> On Fri, 2004-06-04 at 10:59 +0800, Not Zed wrote:
> > On Thu, 2004-06-03 at 22:45 -0400, Rodney Dawes wrote: 
> > > On Thu, 2004-06-03 at 16:38 -0400, William Jon McCann wrote:
> > > > Hi,
> > > > 
> > > > Here is a minor patch to add the HIG border width to the error dialogs.
> > > > 
> > > > OK to commit?
> > > > 
> > > > Jon
> > > 
> > > This isn't the Right Way. This also doesn't make it 12 pixels, it makes
> > > it 13 pixels with the default gtk+ setup. This also doesn't actually
> > > make the dialog HIG-compliant. It needs a lot more changes to acheive
> > > that unfortunately.
> > 
> > Hmm?  It was based on the glade file you provided for it.  Pixel for pixel.
>
> I didn't provide any glade files... Maybe Ben did? I must have been
> really busy at the time, and not gotten a chance to look over it firs

Ahh yes, it was Ben.  Sorry about that.

> t.
> The Icon and Text bits seem to be centered within the dialog, and the
> passphrase/password dialogs add extra widgets that aren't packed within
> a HIG-compliant region.
>
> Anyway, I'll try to get this worked out tomorrow, assuming nothing
> drastic happens with the snapshots, as has been the recent trend, and
> keeping me away from doing much hacking on HIG stuff. :-/

Well hopefully, even if so, the HIG stuff shouldn't be too hard to work through once you have time.

I figure Bill's patches are good to get in, they're generally an improvement, and even if they're not 100% correct they're probably not any more work to fix after being applied, and/or at least they bring attention to stuff which might not be getting any.  There are quite a few wildly non-hig things left opposed to a few pixel-imperfect things which aren't really as important.

--

Michael Zucchi <notzed ximian com> Ximian Evolution and Free Software Developer