Re: [evolution-patches] Re: Prettify folder property dialog

[Not Zed <notzed ximian com>]

On Thu, 2004-06-03 at 12:07 +0200, Christian Neumair wrote:
> Am Do, den 03.06.2004, 11:04 Uhr +0200 schrieb Christian Neumair:
> > Am Do, den 03.06.2004, 10:47 Uhr +0800 schrieb Not Zed:
> > > On Wed, 2004-06-02 at 12:26 -0400, Rodney Dawes wrote: 
> > > > On Mër , 2004-06-02 at 16:22 +0200, Christian Neumair wrote:
> > > > > Rodney Dawes schrieb: 
> > > > > 
> > > > > > Some comments below. 
> > > > > > 
> > > > > > On Mër , 2004-06-02 at 12:55 +0200, Christian Neumair wrote:
> > > > > >> The attached patch pretifies the folder property dialog and moves it
> > > > > >> towards HIG compliance.
> > > > > >> Any comments/suggestions?
> > > > > > 
> > > > > >> @@ -56,7 +56,7 @@
> > > > > >>         CamelArgV *argv = prop_data->argv;
> > > > > >>         int i;
> > > > > >>         
> > > > > >> -       if (response != GTK_RESPONSE_OK) {
> > > > > >> +       if (response != GTK_RESPONSE_CLOSE) {
> > > > > >>                 gtk_widget_destroy (dialog);
> > > > > >>                 return;
> > > > > >>         }
> > > > > > 
> > > > > > Shouldn't the response always be GTK_RESPONSE_CLOSE? Why would we check
> > > > > > for !=? We're just going to close it all the time no matter what we get
> > > > > > here, aren't we?
> > > > > 
> > > > > There is also a destroy reponse. 
> > > > 
> > > > And it presumably also destroys the window. So, I don't see why we need
> > > > to handle them differently, unless we are doing something when we click
> > > > the "Close" button.
> > > 
> > > Shouldn't it remain an Ok button anyway?  This dialogue takes input.
> > > 
> > > And it has values which need to be applied when you hit ok.  They
> > > can't be instant apply - reindexing a folder can minutes to hours.
> > 
> > You gave a random comment without taking a look at the source code.
> > The dialog takes no input at all. It displays the folder name in a
> > label. If you want to rename a folder, you'll have to right-click it and
> > select the rename action.

You gave a silly response without reading what i'd written.  I know exactly what the bloody thing does since I wrote it.

> OK, slight addition: It *can* take additional input (toggle buttons
> etc.). That input is queried on close as well. Because your performance
> argument counts, the code that adds these additional input widgets will
> have to listen for changes and apply them itself if performance allows
> it.
Except it wont, it will simply apply when you hit ok.

--

Michael Zucchi <notzed ximian com> Ximian Evolution and Free Software Developer