Re: [evolution-patches] patch for fix non rfc2047 compliant i18n mailer

[Jeffrey Stedfast <fejj ximian com>]

On Sun, 2004-05-30 at 07:15, cantona wrote:
> Hi all,
> 
> Here is the newest patch. Tested and works fine.
> 
> Cantona.
> 

> Index: camel/ChangeLog
> ===================================================================
> RCS file: /cvs/gnome/evolution/camel/ChangeLog,v
> retrieving revision 1.2152
> diff -u -r1.2152 ChangeLog
> --- a/camel/ChangeLog   27 May 2004 17:56:51 -0000      1.2152
> +++ b/camel/ChangeLog   30 May 2004 11:10:30 -0000
> @@ -1,3 +1,10 @@
> +2004-05-30  Cantona Su  <paradisetux hotmail com>
> +                                                                               
> +       * camel-mime-utils.c (fix_broken_rfc2047): Added
> fix_broken_rfc2047()
> +       for fix non rfc2047 compliant i18n mailer. #58555
> +       (camel_header_decode_string): call fix_broken_rfc2047() before
> return
> +       the string to
> header_decode_text().                                     
> +
>  2004-05-27  Jeffrey Stedfast  <fejj novell com>
>  
>         Fixes bug #59191.
> Index: camel/camel-mime-utils.c
> ===================================================================
> RCS file: /cvs/gnome/evolution/camel/camel-mime-utils.c,v
> retrieving revision 1.208
> diff -u -r1.208 camel-mime-utils.c
> --- a/camel/camel-mime-utils.c  24 May 2004 08:02:10 -0000      1.208
> +++ b/camel/camel-mime-utils.c  30 May 2004 11:10:32 -0000
> @@ -1171,10 +1171,58 @@
>  
>  char *
>  camel_header_decode_string (const char *in, const char
> *default_charset)
> -{
> +{      
>         if (in == NULL)
>                 return NULL;
> -       return header_decode_text (in, strlen (in), default_charset);
> +       
> +       return header_decode_text (fix_broken_rfc2047(in), strlen
> (fix_broken_rfc2047(in)), default_charset);
> +}

now instead of just leaking the result of fix_broken_rfc2047() only once
as with your last patch, you now leak it twice.

also, as NotZed said - you are going about solving this problem the
wrong way and your pointer usage in fix_broken_rfc2047() is highly
suspect.

Jeff

-- 
Jeffrey Stedfast
Evolution Hacker - Ximian, Inc.
fejj ximian com  - www.ximian.com