Re: [evolution-patches] another camel-mime-utils fix similar to previous one

[Not Zed <notzed ximian com>]

looks good.

i wonder if there's any way to check this sort of type-mismatch at compile-time, even if it only checks when you're compiling in gcc.

On Fri, 2004-07-30 at 10:22 -0400, Jeffrey Stedfast wrote:

this one was spotted by Suresh

I somehow missed it when I fixed the other usage of it earlier in the
code.

Jeff

text/plain attachment (patch)

? patch
Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/evolution/camel/ChangeLog,v
retrieving revision 1.2231
diff -u -r1.2231 ChangeLog
--- ChangeLog	29 Jul 2004 14:24:10 -0000	1.2231
+++ ChangeLog	30 Jul 2004 14:26:25 -0000
@@ -1,3 +1,9 @@
+2004-07-30  Jeffrey Stedfast  <fejj ximian com>
+
+	* camel-mime-utils.c (camel_header_encode_string): Similar fix as
+	below in a later if-statement. Thanks to Suresh for spotting this
+	one.
+
 2004-07-28  Jeffrey Stedfast  <fejj novell com>
 
 	* camel-mime-utils.c (camel_header_encode_string): Fixed an ABR
Index: camel-mime-utils.c
===================================================================
RCS file: /cvs/gnome/evolution/camel/camel-mime-utils.c,v
retrieving revision 1.211
diff -u -r1.211 camel-mime-utils.c
--- camel-mime-utils.c	29 Jul 2004 14:24:10 -0000	1.211
+++ camel-mime-utils.c	30 Jul 2004 14:26:32 -0000
@@ -1379,7 +1379,7 @@
 			last_was_space = FALSE;
 		}
 		
-		if (!camel_mime_is_lwsp (c) && !word)
+		if (!(c < 256 && camel_mime_is_lwsp (c)) && !word)
 			word = inptr;
 		
 		inptr = newinptr;

-- 







Michael Zucchi <notzed ximian com>

"born to die, live to work, it's all downhill from here"

Novell's Evolution and Free Software Developer