Re: [evolution-patches] patch for bug#57127 calendar

[Rodrigo Moya <rodrigo novell com>]

On Thu, 2004-07-29 at 04:50 -0600, P Chenthill wrote:
> Hi, 
> I have attached the patch which enables to view the category
> information in the calendar. 
>  
some comments below

> @@ -331,6 +387,9 @@
>         EGwItemOrganizer *organizer;
>         EGwItemType item_type;
>  
> +       default_zone = e_cal_backend_groupwise_get_default_zone
> (cbgw);
> 
you seem to not be using 'default_zone' in the new code, so why is it
declared?

> +EGwConnection *
> +e_cal_backend_groupwise_get_connection (ECalBackendGroupwise *cbgw) {
> +
> +       g_return_val_if_fail (E_IS_CAL_BACKEND_GROUPWISE (cbgw),
> GNOME_Evolution_Calendar_InvalidObject);
> +
This is wrong, you should return NULL, not an integer (which is what
GNOME_Evolution_Calendar_InvalidObject is). The same happens for
get_categories_by_id, get_categories_by_name and get_default_zone.

Apart from that, it looks ok to me.
-- 
Rodrigo Moya <rodrigo novell com>