Re: [evolution-patches] ABR patch for camel's rfc2047 encode_string

[Suresh Chandrsekharan <suresh chandrasekharan sun com>]

Agree. But check for '\0' should not have cused much harm as the alternative suggested. If you say 'I only meant to review patches more closely', thats fine, but people who read your comments in bug report will interpret that as this bug is caused by screw up from our part. I was only objecting to that part of your comments.


W liście z czw, 29-07-2004, godz. 22:15, Jeffrey Stedfast pisze: 
> On Fri, 2004-07-30 at 01:10, Suresh Chandrsekharan wrote:
> > No finger pointing intented, but it was Jeff who told me to use
> > camel_mime_is_lwsp, in the original patch I sent this call was not
> > there.
> > 
> > http://bugzilla.ximian.com/showattachment.cgi?attach_id=7767
>
> \0 is not LWSP! :-)
>
> I only meant we need to review patches more closely for niggles like
> this. I didn't catch it either until just yesterday so it's just as much
> to blame on me for missing it the first time around.
>
> Jeff
>
> _______________________________________________
> evolution-patches mailing list
> evolution-patches lists ximian com
> http://lists.ximian.com/mailman/listinfo/evolution-patches