Re: [evolution-patches] Pilot Settings

[Rodrigo Moya <rodrigo novell com>]

On Thu, 2004-07-22 at 14:48 -0400, JP Rosevear wrote:
> On Tue, 2004-07-20 at 12:38 -0700, Chris Toshok wrote:
> > IMO we shouldn't be storing uids for sources in gconf keys.  this is
> > just as fragile as when we were storing uris back in the 1.4 days.
> > 
> > If you need to tag a particular source for a function, set a property on
> > that source.  That way, if the source is removed, the connection will be
> > as well.
> 
> The attached patch uses the "pilot-sync" property instead.
> 

> +       
> +       if (!e_cal_get_sources (&c->source_list,
> E_CAL_SOURCE_TYPE_TODO, NULL))
> +               c->source_list = NULL;
> +       if (c->source_list) {
> +               c->source = e_pilot_get_sync_source (c->source_list);
> +               if (c->source)
> +                       g_object_ref (c->source);
> +               else
> +                       c->source = e_source_list_peek_source_any (c-
> >source_list);
> +       }
> +       
why do we _ref the object in one case and not in the other? I guess you
then _unref it somewhere, so if it's being ref'ed only in one case, the
_unref might fail, right?

the rest of the calendar part looks ok.

cheers