Re: [evolution-patches] Re: Improve folder treeview order




> OK, thanks for your suggestions! I've changed that.

Anybody willing to review it?


Sorry, must've got lost in the wash.

first, we don't use g*types in the mail code, but thats nothing major.

second you probably want to mark your structures as "static const", and the cmp pointer as only "const", you don't want it static.

i suggest you set the tables up as static globals anyway, which is how we do things elsewhere as a rule.

anyway did we ever get ui team approval, since it changes the ui.

--
Michael Zucchi <notzed ximian com>
"born to die, live to work, it's all downhill from here"
Novell's Evolution and Free Software Developer


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]