Re: [evolution-patches] 61451



On Fri, 2004-07-16 at 12:59 -0400, JP Rosevear wrote:
> This breaks strings freeze, but in 1.4 we made some lame "object not
> found" message.  This is cleaner and product design ok'ed the new
> message.

> @@ -1231,7 +1243,7 @@
>         case ICAL_METHOD_CANCEL:
>                 itip_desc = _("<b>%s</b> has cancelled a meeting.");
>                 itip_title = _("Meeting Cancellation");
> -               options = get_cancel_options ();
> +               options = get_cancel_options (priv->current_ecal ?
> TRUE : FALSE, ICAL_VEVENT_COMPONENT);
>  
>                 /* Provide extra info, since might not be in the
> component */
>                 adjust_item (itip, priv->comp);
> @@ -1299,7 +1311,7 @@
>         case ICAL_METHOD_CANCEL:
>                 itip_desc = _("<b>%s</b> has cancelled a task.");
>                 itip_title = _("Task Cancellation");
> -               options = get_cancel_options ();
> +               options = get_cancel_options (priv->current_ecal ?
> TRUE : FALSE, ICAL_VEVENT_COMPONENT);
> 
is this code supposed to work only with events? Since you have a tasks-
related message above, I guess we should support also tasks here,
shouldn't we?

apart from that, it looks ok.

cheers




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]