Re: [evolution-patches] [calendar] patch for #57142

[JP Rosevear <jpr novell com>]

On Fri, 2004-07-16 at 10:12 +0200, Rodrigo Moya wrote:
> On Fri, 2004-07-16 at 01:59 -0400, JP Rosevear wrote:
> > On Thu, 2004-07-15 at 19:52 +0200, Rodrigo Moya wrote:
> > > On Thu, 2004-07-15 at 14:35 +0200, Rodrigo Moya wrote:
> > > > Updated patch for this, which makes ECalComponent use the same mechanism
> > > > we use in the event editor to keep track of alarms that need a
> > > > description. Whenever we change the component's summary, all the alarms'
> > > > descriptions are updated if needed.
> > > 
> > > updated patch after some talk with JP on IRC, now including an evolution
> > > part.
> > 
> > Looks good except I think the case where the summary changes and we have
> > a custom alarm description is not covered - set_alarm_description_cb
> > should make sure the previous summary and the current alarm description
> > are the same (I believe the event editor code does this) before updating
> > the description.
> > 
> right. updated patch attached.

Looks good.

-JP
-- 
JP Rosevear <jpr novell com>
Novell, Inc.