Re: [evolution-patches] patch for addressbook bug #58639

[Chris Toshok <toshok ximian com>]

committed.

On Tue, 2004-07-13 at 03:09 +0200, Hans Petter Jansson wrote:
> On Mon, 2004-07-12 at 12:01 -0700, Chris Toshok wrote:
> 
> > problem here is the pending_mutex isn't recursive, and we were calling
> > e_data_book_view_notify_remove (which locks the mutex) from
> > e_data_book_view_notify_update (which already held the lock).  Fix is to
> > call the already-locked version (notify_remove).
> > 
> > The e-book-view-listener change is partially for performance (there's no
> > reason to do two more round trips to update the refcount -- that I can
> > see, someone can argue with me if they want :)  Also, once I fixed the
> > mutex problem, the release_unref call was hanging.  Now everything is
> > working (and it's a little faster too when doing searches).
> 
> Looks good.
> 
> --
> Hans Petter
> 
> _______________________________________________
> evolution-patches mailing list
> evolution-patches lists ximian com
> http://lists.ximian.com/mailman/listinfo/evolution-patches
>