Re: [evolution-patches] fix for bug #61385

[Not Zed <notzed ximian com>]

Looks good.

(From iana.org:)

Name: GB2312  (preferred MIME name)
MIBenum: 2025
Source: Chinese for People's Republic of China (PRC) mixed one byte, 
        two byte set: 
          20-7E = one byte ASCII 
          A1-FE = two byte PRC Kanji 
        See GB 2312-80 
        PCL Symbol Set Id: 18C
Alias: csGB2312

On Mon, 2004-07-12 at 14:01 -0400, Jeffrey Stedfast wrote:

http://bugzilla.ximian.com/show_bug.cgi?id=61385

just edited e-charset-picker.c and chanegd the string. nothing fancy.

since GB2312 is both the preferred name for iconv and (apprently? I
can't reach iana.org so I can't look it up easily) the internet accepted
charset name, this should be ok.

Jeff

Plain text document attachment (61385.patch)

? 61385.patch
Index: ChangeLog
===================================================================
RCS file: /cvs/gnome/evolution/widgets/misc/ChangeLog,v
retrieving revision 1.317
diff -u -r1.317 ChangeLog
--- ChangeLog	1 Jul 2004 14:51:57 -0000	1.317
+++ ChangeLog	12 Jul 2004 17:45:30 -0000
@@ -1,3 +1,7 @@
+2004-07-12  Jeffrey Stedfast  <fejj novell com>
+
+	* e-charset-picker.c: s/GB-2312/GB2312/ - fixes bug #61385.
+
 2004-06-24  Rodney Dawes  <dobey novell com>
 
 	* e-error.c (e_error_newv): Fix alignment of the icon to be 0x0
Index: e-charset-picker.c
===================================================================
RCS file: /cvs/gnome/evolution/widgets/misc/e-charset-picker.c,v
retrieving revision 1.19
diff -u -r1.19 e-charset-picker.c
--- e-charset-picker.c	14 Apr 2004 21:30:54 -0000	1.19
+++ e-charset-picker.c	12 Jul 2004 17:45:30 -0000
@@ -92,7 +92,7 @@
 	{ "BIG5HKSCS", E_CHARSET_CHINESE, N_("Traditional") },
 	{ "EUC-TW", E_CHARSET_CHINESE, N_("Traditional") },
 	{ "GB18030", E_CHARSET_CHINESE, N_("Simplified") },
-	{ "GB-2312", E_CHARSET_CHINESE, N_("Simplified") },
+	{ "GB2312", E_CHARSET_CHINESE, N_("Simplified") },
 	{ "HZ", E_CHARSET_CHINESE, N_("Simplified") },
 	{ "ISO-2022-CN", E_CHARSET_CHINESE, N_("Simplified") },
 	{ "KOI8-R", E_CHARSET_CYRILLIC, NULL },

--

Michael Zucchi <notzed ximian com> Novell's Evolution and Free Software Developer