Re: [evolution-patches] NNTP one-liners

[Not Zed <notzed ximian com>]

On Fri, 2004-01-30 at 11:03 -0500, Meilof wrote:
> Not Zed wrote:
> 
> >has it?  not that i know of.  i forgot about your patch and made some
> >changes to the address handling though, while fixing another bug, so
> >your patch will need updating (the stuff in composer/).
> >
> Oh, that's probably it then. Just noticed that some things were already 
> updated with things that were in my patch as well (e.g. 
> e_msg_composer_hdrs_set_post_to_list).
> 
> >i know at least one of the things is wrong though, you shouldn't be
> >changing em-folder-tree.c at all, NULL is a perfectly valid input to
> >camel_store_get_folder_info for top.
> >
> The point is not that it is an invalid input, the point is that later 
> on, the code in the folder tree does this:
> 
> >/     /* FIXME: camel's IMAP code is totally on crack here, @top's
> />/      * folder info should be @fi and fi->child should be what we
> />/      * want to fill our tree with... *sigh* */
> />/     if (m->top && m->fi && !strcmp (m->fi->full_name, m->top)) {
> />/         if (!(fi = m->fi->child))
> />/             fi = m->fi->sibling;
> />/     } else
> />/         fi = m->fi;
> /
> 
> As I understand it, this code is meant to check whether the first folder 
> info item it receives is for the top node we requested (so in that case, 
> it moves on to the children, and, according to the comment above, this 
> should be the case). This works if m->fi is not NULL, but if it's NULL, 
> the check is obviously not done. In this case, you'd see a hierarchy like:
> 
> news.wanadoo.nl
>   -> .
>     -> foo
> 
> I did find it kind of odd that other stores shouldn't have this problem 
> though...

Well that code checks for m->top being null ...

FWIW, IIRC, the imap (or one of the others) code just does:
if top == NULL
 top = "";

anyway, so you can just do the same in nntp.  But the interface is ...
NULL top is ok input.

Jeff really should've just fixed imap, if its returning a funny return,
rather than hacking around it in the mailer!