Re: [evolution-patches] [PATCH] leak fix(es) in e-xml-hash-utils

[Rodrigo Moya <rodrigo ximian com>]

On Wed, 2004-01-21 at 22:54 +0100, Thomas Cataldo wrote:
> On Tue, 2004-01-20 at 18:40, Rodrigo Moya wrote:
> > looks ok to me, although I'd change:
> > with a more meaningful message, like 'Found a key with no value'.
> 
> Done.

> +               if (!key) {
> +                       g_warning ("Found a key with no value!!");
> +                       continue;
> +               }
> 
I didn't mean this message, which should clearly be 'Key not found' or
something similar...

> +
>                 value = xmlNodeListGetString (doc, node-
> >xmlChildrenNode, 1);
> -               if (!key || !value) {
> +               if (!value) {
> +                       xmlFree (key);
>                         g_warning ("Found an entry with missing
> properties!!");
> 
but this one.

also, the patch is missing a ChangeLog entry.

cheers