Re: [evolution-patches] Fix for contact-editor dialog.

[JP Rosevear <jpr ximian com>]

On Wed, 2004-01-21 at 01:31, Not Zed wrote:
> On Wed, 2004-01-21 at 01:38 -0500, Nat Friedman wrote:
> > On Wed, 2004-01-21 at 01:05, Not Zed wrote:
> > > On Wed, 2004-01-21 at 00:49 -0500, Nat Friedman wrote:
> > > > The Blog URL entry widget is missing from this dialog.  The attached
> > > > patch fixes it.  Also see:
> > > > 
> > > > 	http://bugzilla.ximian.com/show_bug.cgi?id=53095
> > > > 
> > > > Toshok tells me Tuomas should approve this since it's a UI change.
> > > 
> > > I think JP too FWIW, since we're in ui freeze.
> > 
> > Okay.  Though this is obviously a bug -- the entry widget is missing
> > altogether, though there's a table cell for it and the label is there.
> 
> Yeah ...
> 
> I'd actually like to know where the line crosses here, JP, whats the
> differentiation between a bugfix and a ui change, or do we just bug you
> with them all?  :)

Well considering the label is actually there and the code, this is a
bug.  Basically you mostly want to bug me or Tuomas probably unless its
obvious and trivial, ie spelling mistake, spacing that doesn't match the
rest of the dialog or something along those lines.

> And do things like fixing ui spacing really break the 'ui freeze', for
> example.

Spacing counts as HIGification (assuming you are higifying the spacing),
so if Tuomas is ok with the spacing changes you are making its fine.

-JP
-- 
JP Rosevear <jpr ximian com>
Ximian, Inc.