Re: [evolution-patches] [PATCH] leak fix(es) in e-xml-hash-utils

[Rodrigo Moya <rodrigo ximian com>]

On Wed, 2004-01-21 at 01:03 +0100, Thomas Cataldo wrote:
> On Tue, 2004-01-20 at 18:40, Rodrigo Moya wrote:
> > On Tue, 2004-01-20 at 00:28 +0100, Thomas Cataldo wrote:
> > > Hi,
> > > 
> > > Here's a patch to fix a few leaks in e-xml-hash-utils. This was
> > > previously reported on bugzilla as
> > > http://bugzilla.ximian.com/show_bug.cgi?id=53000
> > > 
> > looks ok to me, although I'd change:
> > 
> > > -               if (!key || !value) {
> > > +               if (!value) {
> > > +                       xmlFree (key);
> > >                         g_warning ("Found an entry with missing
> > > properties!!");
> > > 
> > with a more meaningful message, like 'Found a key with no value'.
> > 
> > cheers
> 
> I don't really know the rules of the evolution-patch's list. Do you need
> need me to resend it with an updated message ?
> 
you need approval from another Evolution maintainer, so yes, resend the
patch with the change in.

cheers