Re: [evolution-patches] NNTP one-liners

[Jeffrey Stedfast <fejj ximian com>]

On Wed, 2004-01-14 at 09:03, Meilof wrote:
> Meilof wrote:
> 
> > Hello,
> >
> > Some minor changes to NNTP-related code, basically just what Not Zed 
> > and Jeffrey suggested, and a small bugfix for a problem I found myself.
> 
> ... and a fix for a nntp get folder info crash as well.
> 
> 
> Meilof
>  -- meilof wanadoo nl

[snip]
> @@ -1802,7 +1802,7 @@
>  	m->root = gtk_tree_row_reference_copy (row);
>  	m->store = store;
>  	m->emft = emft;
> -	m->top = top ? g_strdup (top) : NULL;
> +	m->top = top ? g_strdup (top) : "";
>  	m->flags = CAMEL_STORE_FOLDER_INFO_FAST | CAMEL_STORE_FOLDER_INFO_RECURSIVE;
>  	m->select_uri = g_strdup (uri);
>  	

this change is wrong. when we later go to g_free (m->top), you'll be
trying to free a static string. bad things will happen :-)

your nntp_get_folder_info() code is supposed to be able to handle NULL
and treat it as a toplevel query (same as the other stores).

also, can you not modify every blank line? it makes the patch far larger
than it needs to be...

Jeff

-- 
Jeffrey Stedfast
Evolution Hacker - Ximian, Inc.
fejj ximian com  - www.ximian.com