Re: [evolution-patches] imap fixes

[Not Zed <notzed ximian com>]

One change i'd suggest, instead of passing &changes and allocating it in
response_update_flags() you should allocate it in the caller and pass it
directly.

i.e.


+                                       g_array_free (expunged, TRUE);
+                                       expunged = NULL;
+                               }
+
+                               camel_imap_response_update_flags(store,
response->folder,
+                                                                number,
p+8, &changes);


the call becomes ->

  if (changes == NULL)
	changes = camel_folder_change_info_new();
   camel_imap_response_update_flags(store, response->folder, number, p
+8, changes);

On Mon, 2004-01-12 at 21:51 +0200, Timo Sirainen wrote:
> a) create new resp-text-code handler where to handle [ALERT]. Easier to
> add other handlers there if needed. resp-text-code handler is now called
> from both tagged and untagged replies.
> 
> b) if server notifies of flag changes, update your own state
> 
> Applies cleanly for 1.4.5 too which I'm using now.
> 
> A bit ugly though.. :)