Re: [evolution-patches] Mailer bug #127521: Inline PGP support for evolution (part A: only sending), reviewed

[Jeffrey Stedfast <fejj ximian com>]

On Sun, 2004-01-11 at 23:35, Not Zed wrote:
> On Fri, 2004-01-09 at 00:50 -0600, Bohumir Jelinek wrote:
> > This allows Evolution to send clearsigned messages.
> > 
> > @@ -183,6 +183,7 @@
> >  
> >  /* utility functions */
> >  int		     camel_cipher_canonical_to_stream(CamelMimePart *part, guint32 flags, CamelStream *ostream);
> > +int		     camel_cipher_data_wrapper_to_canon_stream (CamelDataWrapper *dw, guint32 flags, CamelStream *ostream);
> 
> There should probably be some consistency here, since they both do
> essentially the same thing.
> 
> Actually the second is hardly needed, since it doesn't actually contain
> much code, the other is needed since it needs to change the parts also.
>  
> 
> 
> I guess teh patch looks essentially ok.  I didn't think of this earlier,
> but it probably makes sense just to have a 'mode' on the gpg cipher
> context for clearsign vs mime sign, the same way the smime context has a
> mode to mime sign vs envelope sign.  The same mode setting would affect
> encryption mode as well.

yea, this is probably the nicest way of doing it...

> 
> Then all the details can be handled in the context, and the creation
> code in the composer is simpler.

this would be nice.

Jeff

> 
>  Z
> 
> 
> _______________________________________________
> Evolution-patches mailing list
> Evolution-patches lists ximian com
> http://lists.ximian.com/mailman/listinfo/evolution-patches
-- 
Jeffrey Stedfast
Evolution Hacker - Ximian, Inc.
fejj ximian com  - www.ximian.com