[evolution-patches] Re: Addressbook ebook_async changes patch



On Thu, 2004-01-01 at 09:14, Ross Burton wrote:
Hi,

Attached is a patch to fix the compilation of the addressbook when the
e_book_async patches I mailed earlier are applied.

Regards,
Ross

hm, these changes look ok aside from the e-contact-print.c changes.  It appears that in some places you're still using a char* for ctxt->query, and in others an EBookQuery, specifically:

@@ -1008,7 +1009,7 @@
        g_object_set_data(G_OBJECT(dialog), "uses_book", GINT_TO_POINTER (TRUE));
        g_object_set_data(G_OBJECT(dialog), "uses_list", GINT_TO_POINTER (FALSE));
        g_object_set_data(G_OBJECT(dialog), "book", book);
-       g_object_set_data(G_OBJECT(dialog), "query", g_strdup(query));
+       g_object_set_data(G_OBJECT(dialog), "query", e_book_query_from_string  (query));
        g_signal_connect(dialog,
                         "response", G_CALLBACK(e_contact_print_response), NULL);
        g_signal_connect(dialog,
@@ -1055,7 +1056,7 @@
                                                                            72 * style->page_height));
 #endif
        ctxt->book = book;
-       ctxt->query = g_strdup(query);
+       ctxt->query = e_book_query_from_string (query);
        ctxt->contacts = NULL;
        g_object_ref(book);
        e_contact_do_print(book, ctxt->query, ctxt);




[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]