[evolution-patches] Re: A patch for calender

["kidd.wang" <kidd wang sun com>]

Hi,
       I've revised the patch as you suggestted and 
Harry<harry lu sun com> has help check it in. Thanks for your review:-)

Rodrigo Moya wrote:

> On Mon, 2004-01-05 at 10:01, kidd.wang wrote:
>  
>
> > JPR and Rodrigo,
> >    Would you please take a look at this patch. Thanks:)
> > kidd.wang wrote:
> >    
> >
> > > @@ -246,6 +249,9 @@
> > > 	model = e_calendar_table_get_model (e_tasks_get_calendar_table (tasks));
> > > 	e_cal_is_read_only (e_cal_model_get_default_client (model), &read_only, NULL);
> > >
> > > +	bonobo_ui_component_set_prop (uic, "/commands/TasksOpenTask", "sensitive",
> > > +				      n_selected != 1 || read_only ? "0" : "1",
> > > +				      NULL);
> > >      
> here, you don't need the 'read_only' flag to enable / disable the item.
> Even if the calendar is read-only, the task can still be opened in the
> editor, so this should just be:
>
> bonobo_ui_component_set_prop (uic, "/commands/TasksOpenTask",
> "sensitive",
> 	n_selected != 1 ? "0" : "1",
> 	NULL);
>
> apart from that, it looks ok
>
> cheers
>
>