Re: [evolution-patches] bug 37329, cleaning up temp files from older sessions

[Jeffrey Stedfast <fejj ximian com>]

sure, looks ok.

Jeff

On Fri, 2004-02-27 at 02:55, Not Zed wrote:
> I came up with the attached patch.  Any objections?  This is something
> we covered in the last meeting, and implements one of the solutions
> suggested.
> 
> It removes any internal recording of the filename, and just expires
> files based on their access time.  Currently set to a minimum of 2
> hours.
> 
> It also (optionally) creates the files in ~/.evolution/cache/tmp instead
> of /tmp.  And if you do build it to talk to /tmp it just uses evolution-
> uid not evolution-uid-pid anymore, so it can find it later.
> 
> I just realised now that it leaks the filenames - but it basically
> leaked them before anyway (just kept them around for the entire session
> in a list).  To fix that requires fixing everywhere its used to free the
> strings I guess, which isn't a big task.
> 
> I think the atime checks will work properly for expiring directories,
> etc.  My testing suggests that it should.  It depends a bit on the
> filesystem mind you, and you can mount things with noatime, but then its
> just the same as ctime anyway - and should still work.
> 
>  Michael
-- 
Jeffrey Stedfast
Evolution Hacker - Ximian, Inc.
fejj ximian com  - www.ximian.com