[evolution-patches] mail, patch to fix focus issue of Account Assistant
- From: Eric Zhao <eric zhao sun com>
- To: evolution-patches ximian com
- Subject: [evolution-patches] mail, patch to fix focus issue of Account Assistant
- Date: Wed, 25 Feb 2004 22:03:07 +0800
Hi,
Atttached is a patch to fix the Tab navigation bug of Account
Assistant, which can be reproduced by the following steps:
(1) Invoke your evo,
(2) Select Tool->Settings...
(3) Select mail Account->Add to open Account Assistant
After the Account Assistant is initiated, you can find that using Tab
key to navigate around "Cancel", "Forward" buttons is impossible.
This bug is caused by the following code in
evolution/mail/mail-account-gui.c:618
gtk_widget_grab_focus (GTK_WIDGET (gui->transport.hostname));
This sentence transfers the focus to the hostname edit, but when
this function is called, the wizard is just on the start page, and
the hostname edit is unvisible, so Tab navigation failed.
Also I found that the code can't get the expected result -- set focus
to the host edit when the wizard is on the "Sending Email" page. So I
just commented this sentence.
This patch has been tested on my box, please help review. Thank you!
Changelog:
* mail-account-gui.c: (transport_type_changed): Commented
grabbing focus on hostname edit, fix the focus issue of
Account Assistant.
Regards,
--
Eric Zhao <eric zhao sun com>
Index: mail-account-gui.c
===================================================================
RCS file: /cvs/gnome/evolution/mail/mail-account-gui.c,v
retrieving revision 1.148
diff -u -r1.148 mail-account-gui.c
--- mail-account-gui.c 24 Feb 2004 21:31:19 -0000 1.148
+++ mail-account-gui.c 25 Feb 2004 13:58:47 -0000
@@ -615,7 +615,7 @@
label = glade_xml_get_widget (gui->xml, "transport_host_label");
if (CAMEL_PROVIDER_ALLOWS (provider, CAMEL_URL_PART_HOST)) {
- gtk_widget_grab_focus (GTK_WIDGET (gui->transport.hostname));
+ /*gtk_widget_grab_focus (GTK_WIDGET (gui->transport.hostname));*/
gtk_widget_show (GTK_WIDGET (gui->transport.hostname));
gtk_widget_show (label);
} else {
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]