Re: [evolution-patches] widgets, patch to close Settings dialog by ESC key

[Eric Zhao <eric zhao sun com>]

Hi,

First I think using ESC key to close preferences dialog is convenient to
the users. The fact that other GNOME apps don't provide this feature
doesn't mean it's unuseful. Actually many GNOME apps even don't provide
an OK or Apply button, so the changes will take effect as soon as
possible, and you even can't cancel the changes by closing these
dialogs. Then take a look at some other apps, such as mozilla, gimp-2,
most KDE apps, etc, their preferences dialogs are all can be closed by
ESC key.

Second, I think people just expect using ESC key to close the
preferences dialog and canel the changes recently made(not applied
before). Undoing the changes after applying them should be the expected
behaviour of "Undo" button, or something similar. This feature is not
very necessary and not easy to implement, I think.

Regards,
-- 
Eric Zhao <eric zhao sun com>
 
--
On Fri, 2004-02-20 at 18:10 -0500, Rodney Dawes wrote:

> This is the wrong behaviour, yeah. It's not a cancel button. If you make
> changes, and then click it, after clicking apply, it doesn't undo your
> changes. If one hits ESC, the changes are expected to be undone. There
> are discussions about what the ideal way to handle things like this,
> going on.
> 
> -- dobey
> 
> On Pre , 2004-02-20 at 17:02 -0500, Jeffrey Stedfast wrote:
> 
> > I don't think we want this behaviour. Other GNOME apps do not close
> > their preferences dialogs when the user hits ESC so I don't think we
> > should either.
> > 
> > Jeff
> > 
> > On Fri, 2004-02-20 at 08:37, Eric Zhao wrote:
> > > Hi,
> > > 
> > > Attached is a patch to fix the bug that the Settings dialog of
> > > Evolution can't be closed be ESC key. This problem is caused by 
> > > e-multi-config-dialog. 
> > > 
> > >    Since e-multi-config-dialog is derived from GtkDialog, it will 
> > > do nothing when pressing ESC key on this dialog, because the 
> > > e-multi-config-dialog doesn't have an action widget with GTK_RESPONSE_CANCEL
> > > as its response ID. By changing the response ID of "Close" button from 
> > > GTK_RESPONSE_CLOSE to GTK_RESPONSE_CANCEL, the ESC key can work.
> > > 
> > >    I have tested this patch on my box, please help review, thanks!
> > > 
> > > Changelog:
> > >         * e-multi-config-dialog.c: (init): change the response id of
> > >         "CLOSE" button from GTK_RESPONSE_CLOSE to GTK_RESPONSE_CANCEL,
> > >         so that this kind of dialog can be closed by ESC key.
> > 
> > _______________________________________________
> > Evolution-patches mailing list
> > Evolution-patches lists ximian com
> > http://lists.ximian.com/mailman/listinfo/evolution-patches